-
Notifications
You must be signed in to change notification settings - Fork 281
Add JSON Schema Definition for gen_ai.tool.definitions #2942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Cirilla-zmh
wants to merge
7
commits into
open-telemetry:main
Choose a base branch
from
Cirilla-zmh:minghui/tool_definitions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add JSON Schema Definition for gen_ai.tool.definitions #2942
Cirilla-zmh
wants to merge
7
commits into
open-telemetry:main
from
Cirilla-zmh:minghui/tool_definitions
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I63f11ca8081f71b55b793ec88f35ef64bbace8e6 Co-developed-by: Cursor <[email protected]>
Change-Id: Ib6133b3019195e4fa9a54d329ff4b891a281d208 Co-developed-by: Cursor <[email protected]>
76f99f0 to
2a15973
Compare
Member
Author
|
This is the continued PR of #2793 |
3 tasks
lmolkova
reviewed
Oct 20, 2025
Change-Id: Ie116f8bcb9e758b026596b797569b27496b35521 Co-developed-by: Cursor <[email protected]>
lmolkova
reviewed
Oct 20, 2025
Cirilla-zmh
commented
Oct 21, 2025
| format is not supported and SHOULD be recorded in structured form otherwise. | ||
|
|
||
| If instrumentations can reliably deserialize and extract the tool definitions, | ||
| it's RECOMMENDED to only populate required fields (`name`, `type`) of the definition |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether we need to capture 'name' & 'type' by default, considering they are important informations and have no sensitive/huge content? cc @ShipraJain01 @lmolkova
Here is a prototype from spring-ai instrumentation:
options.getToolCallbacks().stream()
.map(
toolCallback -> {
String name = toolCallback.getToolDefinition().name();
String type = "function";
if (messageCaptureOptions.captureMessageContent()) {
return ToolDefinition.create(
type, name, toolCallback.getToolDefinition().description(), toolCallback.getToolDefinition().getArguments());
} else {
return ToolDefinition.create(type, name, null, null);
}
})
.filter(Objects::nonNull)
.forEach(toolDefinitions::append);
alexmojaki
reviewed
Oct 21, 2025
gyliu513
reviewed
Oct 28, 2025
Change-Id: If96268fc1b4d3cd64c0a10437a968cbe5ec83d98 Co-developed-by: Cursor <[email protected]>
Change-Id: Ic5480fbdb1058a2e1ace084c8ce3735484f91c06 Co-developed-by: Cursor <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2721 #1835
Changes
Add JSON schema definition for gen_ai.tool.definitions.
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]